This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH: PR/40416] stop sinking expression if the target bb post dominates from bb


Thank you, Ian.

The ChangeLog is modified to:


ChangeLog:
2009-06-18  Carrot Wei  <carrot@google.com>

        PR/40416
        * tree-ssa-sink.c (statement_sink_location): Stop sinking expression
        if the target bb post dominates from bb.
        * config/i386/i386.c (memory_address_length): Check existance of base
        register before using it.
        * gcc.dg/tree-ssa/ssa-sink-5.c: New testcase.


On Thu, Jun 18, 2009 at 11:50 AM, Ian Lance Taylor<iant@google.com> wrote:
> Carrot Wei <carrot@google.com> writes:
>
>> ChangeLog:
>> 2009-06-18 ?Carrot Wei ?<carrot@google.com>
>>
>> ? ? ? ? PR/40416
>> ? ? ? ? * tree-ssa-sink.c: stop sinking expression if the target bb post
>> ? ? ? ? dominates from bb.
>> ? ? ? ? * config/i386/i386.c: check existance of base register before using it.
>> ? ? ? ? * testsuite/gcc.dg/tree-ssa/ssa-sink-5.c: new test case.
>
> ChangeLog entries should say the function they are changing. ?They
> should be capitalized as complete sentences. ?See many existing
> examples, or
> http://www.gnu.org/prep/standards/html_node/Change-Logs.html .
>
> The testsuite change should go in testsuite/ChangeLog, and therefore
> should not start with "testsuite/".
>
> Ian
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]