This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix trunk profiledbootstrap in fortran FE


On Wed, Jun 10, 2009 at 05:50:19PM +0200, Jakub Jelinek wrote:
> On Wed, Jun 10, 2009 at 08:45:24AM -0700, Steve Kargl wrote:
> > > 	* interface.c (fold_unary): Rename to...
> > > 	(gfc_fold_unary): ... this.
> > > 	(gfc_extend_expr): Adjust caller.
> > 
> > By convention the Fortran FE normally uses the gfc_ prefix
> > on non-static functions.  If the function is static, the 
> > gfc_ is omitted.  I don't recall the origins of this convention.
> > Can you add a small comment above gfc_fold_unary?  Something
> > like
> > 
> > /* gfc_ prefix used to avoid possible conflicts with middle-end
> >    fold_unary() function.  */
> 
> In that case, wouldn't it be better renamed to e.g.
> fold_unary_intrinsic instead (and no extra comment)?
> 

Sure, that works too.

-- 
Steve


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]