This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Whitespace fixes

On Fri, Jun 05, 2009 at 09:41:47PM +0200, Richard Guenther wrote:
>On Fri, Jun 5, 2009 at 9:26 PM, Bernhard
>Reutner-Fischer<> wrote:
>> :ADDPATCH gcc:
>> ? ? ? ?* c-opts.c (c_common_handle_option): Fix whitespace.
>> ? ? ? ?* gthr.h: Ditto.
>> ? ? ? ?* passes.c (rest_of_decl_compilation): Ditto.
>> ? ? ? ?* ipa-struct-reorg.c (do_reorg_1): Fix whitespace in dump output.
>We don't generally do whitespace fixes as that only causes merge issues
>for others.  Instead when people do changes they may fixup whitespace
>issues around their changes.

Yes, i understand. This begs for two questions:
1) Is the isolated whitespace-fix in ipa-struct-reorg's dump output ok?
2) Can we have a pre-commit hook that rejects any patch that
   a) leaves whitespace-damage in a file that was touched, forcing
      people to fixup complete files they touch.
   b) has whitespace damage in it's 'diff -U3', i.e. rejects
      If a patch introduces new damage or does not fix nearby existing
My preference would be a) since it would help adhering to coding standards
faster than b), but b) would of course be better than what we have today,
i.e. nothing AFAIK.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]