This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Remove prototypes for long removed vn related functions


On Fri, Jun 5, 2009 at 9:27 PM, Bernhard
Reutner-Fischer<rep.dot.nop@gmail.com> wrote:
> :ADDPATCH gcc:
>
> ? ? ? ?* tree-flow.h (make_value_handle, set_value_handle, sort_vuses,
> ? ? ? ?sort_vuses_heap, vn_lookup_or_add, vn_lookup_or_add_with_stmt,
> ? ? ? ?vn_lookup_or_add_with_vuses, vn_add, vn_add_with_vuses,
> ? ? ? ?vn_lookup_with_stmt, vn_lookup, vn_lookup_with_vuses): Remove
> ? ? ? ?prototypes for removed functions.
> ? ? ? ?(expressions_equal_p): Move to ...
> ? ? ? ?* tree-ssa-sccvn.h: ... here and ...
> ? ? ? ?* matrix-reorg.c: ... adjust includes.

Huh.  expressions_equal_p should likely be private to tree-ssa-sccvn.c.  The
call in matrix-reorg.c is confusing...

Well.  The patch is ok.

Thanks,
Richard.

> Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
> ---
> ?gcc/ChangeLog ? ? ? ?| ? 11 +++++++++++
> ?gcc/matrix-reorg.c ? | ? ?1 +
> ?gcc/tree-flow.h ? ? ?| ? 16 ----------------
> ?gcc/tree-ssa-sccvn.h | ? ?4 ++++
> ?4 files changed, 16 insertions(+), 16 deletions(-)
>
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]