This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch][plugin] Fix bug in pass insertion

From: Olatunji Ruwase <tjruwase at google dot com>
To: Rafael Espindola <espindola at google dot com>
Cc: gcc-patches at gcc dot gnu dot org, Diego Novillo <dnovillo at google dot com>
Date: Fri, 5 Jun 2009 10:33:17 -0700
Subject: Re: [patch][plugin] Fix bug in pass insertion
References: <fe7fd8170906041438v71ebb7f3nb153d44f12456830@mail.gmail.com> <38a0d8450906050711u3693d309nf3ff9c4379117dc1@mail.gmail.com>

On Fri, Jun 5, 2009 at 7:11 AM, Rafael Espindola <espindola@google.com> wrote:
>
> Looks like the patch got corrupted (some of the === lines are broken
> for example).

Sorry about that, I 'll sort that out in future.

> My only request on the patch would be to expand the comment on
> plugin.c to say when repeated insertions would happen (new pass has
> the same name as an existing one). The indentation looks strange, but
> I assume that is because the patch got corrupted.
I 'll expand the comment as suggested.

Thanks

tunji

References:
- [patch][plugin] Fix bug in pass insertion
  - From: Olatunji Ruwase
- Re: [patch][plugin] Fix bug in pass insertion
  - From: Rafael Espindola

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]