This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch, libgfortran] PR 40330 Fix use of saved format strings

From: Jerry DeLisle <jvdelisle at verizon dot net>
To: Janne Blomqvist <blomqvist dot janne at gmail dot com>
Cc: Fortran List <fortran at gcc dot gnu dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Wed, 03 Jun 2009 17:06:05 -0700
Subject: Re: [Patch, libgfortran] PR 40330 Fix use of saved format strings
References: <7b446c2e0906031200x47f4803ak6ebd5dc2e7c442e5@mail.gmail.com> <7b446c2e0906031218o5c813e69u5cd790d438e353b3@mail.gmail.com>

Janne Blomqvist wrote:

On Wed, Jun 3, 2009 at 22:00, Janne Blomqvist <blomqvist.janne@gmail.com> wrote:
Hi,
the attached patch fixes PR 40330. The problem was that for the saved
format strings we were just keeping pointer to the strings that reside
in the st_parameter_dt structure. However, this lives on the stack so
once it goes out of scope the cached entries became invalid. Fixed by
using heap storage.
Regtested on x86_64-unknown-linux-gnu, Ok for trunk and 4.4?
Upon some further though, realloc() is not appropriate here.
Simplified patch attached.
Regtested on x86_64-unknown-linux-gnu, Ok for trunk and 4.4?

Yes and Yes,

Thanks to Joost for spotting this and reducing the test case.

Thanks Janne for quick response. (the realloc made me nervous :) )

Jerry

References:
- [Patch, libgfortran] PR 40330 Fix use of saved format strings
  - From: Janne Blomqvist
- Re: [Patch, libgfortran] PR 40330 Fix use of saved format strings
  - From: Janne Blomqvist

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]