This is the mail archive of the
mailing list for the GCC project.
Re: [Patch, libgfortran] PR 40330 Fix use of saved format strings
On Wed, Jun 3, 2009 at 22:18, Janne Blomqvist <email@example.com> wrote:
> On Wed, Jun 3, 2009 at 22:00, Janne Blomqvist <firstname.lastname@example.org> wrote:
>> the attached patch fixes PR 40330. The problem was that for the saved
>> format strings we were just keeping pointer to the strings that reside
>> in the st_parameter_dt structure. However, this lives on the stack so
>> once it goes out of scope the cached entries became invalid. Fixed by
>> using heap storage.
>> Regtested on x86_64-unknown-linux-gnu, Ok for trunk and 4.4?
> Upon some further though, realloc() is not appropriate here.
> Simplified patch attached.
> Regtested on x86_64-unknown-linux-gnu, Ok for trunk and 4.4?
> Janne Blomqvist
Committed to trunk, reviewed and OK'd on IRC by Tobias B.
Transmitting file data ..
Committed revision 148149.
I'll wait a few days before committing to 4.4.