Re: [trunk<-vta] Re: [vta] fix PCH testsuite regression with DW_AT_MIPS_linkage_name

[Richard Henderson <rth at redhat dot com>]

Alexandre Oliva wrote:
> +  while (--ix)
> +    {
> +      prev = VEC_index (dw_attr_node, die->die_attr, ix - 1);
> +
> +      if (prev->dw_attr == DW_AT_decl_line || prev->dw_attr == DW_AT_name)
> +	{
> +	  VEC_replace (dw_attr_node, die->die_attr, ix, &linkage);
> +	  return;
> +	}
> +      else
> +	VEC_replace (dw_attr_node, die->die_attr, ix, prev);
> +    }

Mostly ok.  But really I'd prefer to see this loop merely
search, then use VEC_pop and VEC_quick_insert to move the
entry.


r~