This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gcc-in-cxx] Remove extern "C" from libdecnumber


"Joseph S. Myers" <joseph@codesourcery.com> writes:

> On Wed, 27 May 2009, Ian Lance Taylor wrote:
>
>> different sources.  I agree that it would be better to have the extern
>> "C" in the libdecnumber header files.  However, that code came from an
>> upstream source.  So the correct approach here is to convince the
>> upstream source to add the extern "C".  In the meantime, I think that
>> something like this patch is better than changing the libdecnumber
>> sources.  Would it make you happier if I moved the #include libdecnumber
>
> We already make local changes to libdecnumber as needed; I don't see a 
> particular problem with doing so here, along with sending the fix 
> upstream, since it seems clear that the correct fix is adding extern "C" 
> to libdecnumber.

OK.  Ben, what is the procedure for sending libdecnumber patches
upstream?  (Perhaps we should introduce libdecnumber/README or
libdecnumber/README.gcc).

I want to annotate the libdecnumber header files with extern "C" when
__cplusplus is defined.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]