This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch, libgfortran] PR 40190 DATE_AND_TIME not thread-safe

From: Janne Blomqvist <blomqvist dot janne at gmail dot com>
Cc: Fortran List <fortran at gcc dot gnu dot org>, gcc-patches at gcc dot gnu dot org
Date: Fri, 29 May 2009 21:12:37 +0300
Subject: Re: [Patch, libgfortran] PR 40190 DATE_AND_TIME not thread-safe
References: <EFC9A544-F9EC-416C-B76E-B98F90BD7078@gmail.com> <7b446c2e0905220340p43904afaxb1b13b7e0454f187@mail.gmail.com>

Janne Blomqvist wrote:

The attached patch adds fallback implementations for localtime_r and
gmtime_r that should work properly on MINGW and other targets where we
support OpenMP and that have threadsafe localtime and gmtime.

Ok for trunk?

PING!

Additionally, to be really sure I have also tested the fallback implementations on Linux. So, this patch ought to

1) Fix the PR on targets that have the _r functions.

2) Fix the PR on targets without the _r functions, but with threadsafe localtime(), gmtime() (MINGW, maybe others?).

3) Doesn't regress on other targets.

4) Does not fix the PR on targets where we support OpenMP, but do not have either the _r functions nor threadsafe localtime/gmtime, if such targets indeed exist at all.

--
Janne Blomqvist

References:
- Re: [Patch, libgfortran] PR 40190 DATE_AND_TIME not thread-safe
  - From: FX
- Re: [Patch, libgfortran] PR 40190 DATE_AND_TIME not thread-safe
  - From: Janne Blomqvist

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]