This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch to solve PR39856


On Fri, May 22, 2009 at 03:25:08PM -0400, Vladimir Makarov wrote:
>> ^^^ This isn't needed IMHO.
>>   
>>> +/* { dg-options "-O3 -fomit-frame-pointer -m32 -msse3 -march=i586" } */
>>>     
>>
>>   
> Why? The above option set will work on x86 and x86_64 without a problem.

Because the decision whether to test with -m32 or -m64 should be tester's
decision (how do you invoke make chec, e.g. with
make check RUNTESTFLAGS="--target_board=unix/\{-m32,-m64\}" 
you want to test both, etc.  Several people have been cleaning tests over
time not to have these...

>> ^^^ And this should IMHO be:
>> /* { dg-options "-O3 -fomit-frame-pointer -msse3" } */
>> /* { dg-options "-O2 -fomit-frame-pointer -march=i586 -msse3" { target ilp32 } } */
>>
>>   
> Is it a typo that the second line contains -O2 instead of -O3?

Yeah, s/-O2/-O3/ there, sorry.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]