This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [plugins] Change plugin_init signature


On Wed, May 20, 2009 at 17:40, Taras Glek <tglek@mozilla.com> wrote:

> 2009-05-20 ÂTaras Glek <tglek@mozilla.com>
>
> gcc/ChangeLog
> Â Â Â * plugin.c (try_init_one_plugin): Updated to new plugin_init API.
> Â Â Â * gcc-plugin.h (plugin_init): Updated signature.
> Â Â Â * gcc-plugin.h (plugin_name_args): Moved to this header.
> Â Â Â * doc/plugins.texi (plugin_init): Updated documention to reflect API
> change.
> Â Â Â * doc/plugins.texi (plugin_name_args): Added to documention.
> gcc/testsuite/ChangeLog
> Â Â Â * gcc.dg/plugin/selfassign.c (plugin_init): Updated to new plugin_init
> signature.
> Â Â Â * g++.dg/plugin/selfassign.c (plugin_init): Updated to new plugin_init
> signature.
> Â Â Â * g++.dg/plugin/dumb_plugin.c (plugin_init): Updated to new
> plugin_init signature.
> Â Â Â * g++.dg/plugin/attribute_plugin.c (plugin_init): Updated to new
> plugin_init signature.

Nice cleanup, thanks.  OK with:

> +@smallexample
> +struct plugin_name_args
> +@{
> +  char *base_name;              /* Short name of the plugin (filename without .so suffix). */
> +  const char *full_name;        /* Path to the plugin as specified with -fplugin=. */
> +  int argc;                     /* Number of arguments specified with -fplugin-arg-.... */

Watch word wrapping.

> +/* Object that keeps track of the plugin name and its arguments. */
> +struct plugin_name_args
> +{
> +  char *base_name;              /* Short name of the plugin (filename without .so suffix). */
> +  const char *full_name;        /* Path to the plugin as specified with -fplugin=. */
> +  int argc;                     /* Number of arguments specified with -fplugin-arg-... */

Likewise.


Diego.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]