This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch ARM] Improve Thumb2 code generation.


On Tue, 19 May 2009 11:09:29 +0100
"Ramana Radhakrishnan" <ramana.radhakrishnan@arm.com> wrote:

> +(define_insn "orsi_notsi_si"
> +  [(set (match_operand:SI 0 "s_register_operand" "=r")
> +	(ior:SI (not:SI (match_operand:SI 2 "s_register_operand"
> "r"))
> +		(match_operand:SI 1 "reg_or_int_operand" "rK")))]
> +  "TARGET_THUMB2"
> +  "orn%?\\t%0, %1, %2"
> +  [(set_attr "predicable" "yes")]
> +)

This is wrong. It can put an immediate in the middle of the
instruction. Might you have meant:

  "orn%?\\t%0, %2, %1"

instead?

Cheers,

Julian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]