This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: Integrate gfortran with MPC


On Wed, May 20, 2009 at 12:48:04AM +0200, Tobias Burnus wrote:
> Kaveh R. GHAZI wrote:
> > In this patch I have converted those functions which already had
> > hand-rolled fortran implementations: ccos, cexp, clog, csin and csqrt.
> >   
> Good!
> 
> > MPC also has implementations for some functions missing in gfortran.
> > Namely ctan, ctanh, ccosh and csinh.  I'll try adding those in a future
> > patch.
> >   
> Note: Those are not yet supported in gfortran. They plus complex inverse
> trigometric functions were added only with the Fortran 2008 standard.
> There is a draft patch attached to PR 33197, which adds them, which I
> think is a prerequisite for your follow-up patch.
> 
> > Okay for mainline?
> >   
> OK. Thanks for your MPFR/MPC work!

No.  The patch may not be correct, but I 
haven't had time to review it.

In particular, Kaveh uses mpfr_get_default_prec to
set the precision.  I believe this should be 
mpfr_get_prec(re or im) depending on Fortran mix
mode rules.
 

-- 
Steve


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]