This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: PR target/39942: Nonoptimal code - leaveq; xchg %ax,%ax; retq


On Mon, May 18, 2009 at 10:15 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> This is the patch I am checking in.
>
> Thanks.
>
> --
> H.J.
> --
> 2009-05-18 ÂH.J. Lu Â<hongjiu.lu@intel.com>
>
> Â Â Â ÂPR target/39942
> Â Â Â Â* config/i386/i386.c (ix86_avoid_jump_misspredicts): Replace
> Â Â Â Âgen_align with gen_pad.
> Â Â Â Â(ix86_reorg): Check ASM_OUTPUT_MAX_SKIP_PAD instead of
> Â Â Â Â#ifdef ASM_OUTPUT_MAX_SKIP_ALIGN.
>
> Â Â Â Â* config/i386/i386.h (ASM_OUTPUT_MAX_SKIP_PAD): New.
> Â Â Â Â* config/i386/x86-64.h (ASM_OUTPUT_MAX_SKIP_PAD): Likewise.
>
> Â Â Â Â* config/i386/i386.md (align): Renamed to ...
> Â Â Â Â(pad): This. ÂReplace ASM_OUTPUT_MAX_SKIP_ALIGN with
> Â Â Â ÂASM_OUTPUT_MAX_SKIP_PAD.
>

This patch causes a bootstrap failure on i386-darwin because
ASM_OUTPUT_MAX_SKIP_ALIGN and ASM_OUTPUT_MAX_SKIP_PAD are defined at
different times. On darwin ASM_OUTPUT_MAX_SKIP_ALIGN is not defined
but ASM_OUTPUT_MAX_SKIP_PAD is defined.

-- Pinski


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]