This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PR40159,trunk,vta,vta4.4] don't succeed on failures in recursive make


On Mon, May 18, 2009 at 09:00:43PM -0300, Alexandre Oliva wrote:
>Andreas Schwab reminds me I'm no longer suited to be a configury
>maintainer :-)
>
>I introduced the regression in PR 40159 in my last check in in the
>trunk, that caused ???make all??? to appear to pass in spite of errors in
>the recursive make.
>
>This patch fixes it.  I'm checking it in.  Sorry about the breakage.

Alex,
This patch seems to cause problems if you aren't building gcc since, in
those cases, neither gcc-bootstrap nor gcc-no-bootstrap are defined.

So, if you are building, for instance, cygwin, you get:

/bin/sh: -c: line 3: syntax error near unexpected token `fi'
/bin/sh: -c: line 3: `fi'

cgf


>for  ChangeLog
>from  Alexandre Oliva  <aoliva@redhat.com>
>
>	PR other/40159
>	* Makefile.tpl (all): Don't end with unconditional success.
>	* Makefile.in: Rebuilt.
>
>Index: Makefile.tpl
>===================================================================
>--- Makefile.tpl.orig	2009-05-18 20:28:04.000000000 -0300
>+++ Makefile.tpl	2009-05-18 20:28:06.000000000 -0300
>@@ -620,16 +620,16 @@ all:
> 	@r=`${PWD_COMMAND}`; export r; \
> 	s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \
> @if gcc-bootstrap
>-	if [ -f stage_last ]; then : ; \
>+	if [ -f stage_last ]; then \
> 	  TFLAGS="$(STAGE$(shell sed s,^stage,, stage_last)_TFLAGS)"; \
> 	  $(MAKE) $(TARGET_FLAGS_TO_PASS) all-host all-target; \
> 	else \
> @endif gcc-bootstrap
>+@if gcc-no-bootstrap
>+	if :; then :; \
>+@endif gcc-no-bootstrap
> 	  $(MAKE) $(RECURSE_FLAGS_TO_PASS) all-host all-target; \
>-@if gcc-bootstrap
>-	fi; \
>-@endif gcc-bootstrap
>-	:
>+	fi
> 
> .PHONY: all-build
> [+ FOR build_modules +]


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]