This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH RFA: -Wc++-compat warning about ++/-- with enum value
- From: Janus Weil <janus at gcc dot gnu dot org>
- To: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- Cc: Janne Blomqvist <blomqvist dot janne at gmail dot com>, Ian Lance Taylor <iant at google dot com>, gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org
- Date: Thu, 14 May 2009 23:31:33 +0200
- Subject: Re: PATCH RFA: -Wc++-compat warning about ++/-- with enum value
- References: <m3k54jn0ys.fsf@google.com> <4A0C7B61.8060803@gmail.com> <20090514202755.GA24879@troutmask.apl.washington.edu>
2009/5/14 Steve Kargl <sgk@troutmask.apl.washington.edu>:
> On Thu, May 14, 2009 at 11:13:21PM +0300, Janne Blomqvist wrote:
>> Ian Lance Taylor wrote:
>> >gcc/fortran/ChangeLog:
>> >
>> >2009-05-14 ?Ian Lance Taylor ?<iant@google.com>
>> >
>> > ? ? * decl.c (match_attr_spec): Change d to unsigned int.
>> > ? ? * dump-parse-tree.c (show_namespace): Change op to int. ?Add cast.
>> > ? ? * interface.c (gfc_check_interfaces): Change i to int. ?Add casts.
>> > ? ? * module.c (read_module): Change i to int. ?Add cast.
>> > ? ? (write_module): Change i to int.
>> > ? ? * symbol.c (gfc_get_namespace): Change in to int.
>> > ? ? (gfc_free_namespace): Change i to int.
>> > ? ? * trans-io.c (gfc_build_io_library_fndecls): Change ptype to
>> > ? ? unsigned int. ?Add cast.
>> > ? ? * trans-types.c (gfc_init_kinds): Change mode to unsigned int.
>> > ? ? Add casts.
>>
>> Fortran parts are Ok. However, since Steve evidently disagrees, I guess
>> we need the opinion of a third Fortran maintainer to break the stalemate.
>>
>
> I don't disagree with the change. ?I'm simply concerned that the
> new requirements of C++ knowledge (even a minimal knowledge) is
> going to raise the bar too high to attract additional gfortran
> contributors. ?Janus is the last fresh blood and he joined our
> merry brood 2+ years ago.
Since I'm just being mentioned here, I will also add my opinion:
For a newbie who wants to get into GCC development there are various
hurdles, but I think C++ would be a minor one (the major ones being
the complexity and sheer size of the GCC code base IMHO, and maybe a
lack of information for developers).
I think for someone who has a decent knowledge of C, it shouldn't be
too much of a problem to learn some additional C++ bits (if he doesn't
already know them).
And btw gfortran has some 'fresher' blood than me, like e.g. Daniel
Kraft and Mikael Morin. I think neither GCC nor gfortran willl
die by a lack of developers anytime soon ;)
Cheers,
Janus