This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Rev 146953 seems not to work proper for mingw targets
- From: Kai Tietz <ktietz70 at googlemail dot com>
- To: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Cc: julian at codesourcery dot com
- Date: Wed, 13 May 2009 20:05:42 +0200
- Subject: Rev 146953 seems not to work proper for mingw targets
Hello,
the patch at http://gcc.gnu.org/ml/gcc-cvs/2009-04/msg01599.html
breaks things for mingw target. I am a bit curious that you duplicate
handles here (which is ok so far), but also close origin without
checking for standard handles. The checks existing like
...
if (in != STDIN_FILENO)
_close (in);
if (out != STDOUT_FILENO)
...
will close it always, because the _dup'ed handle will never have value
STDIN_FILENO for sure. What is the intension of this patch? It looks a
bit wired and wrong so far.
Cheers,
Kai
--
| (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination