This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Bootstrap broken for more than 10 days on cygwin and mingw


On Wed, May 13, 2009 at 05:48:22PM +0200, FX wrote:
> Bootstrap has been broken on two secondary targets, i386-pc-cygwin and  
> i386-pc-mingw32, for at least 10 days now. A patch fixing the issue  
> has been available since May 4th, and is confirmed to fix the issue.  
> Could someone approve it?
> 
> Ian, I know you've committed quite a bit of work to introduce C++  
> compat warnings, could you please take time to review this simple patch?
> 
> Pathc is at: http://gcc.gnu.org/ml/gcc-patches/2009-05/msg00125.html
> Confirmed to bootstrap here: 
> http://gcc.gnu.org/ml/gcc-patches/2009-05/msg00308.html

I would tend to prefer that you changed the enum casts of 0, to the proper
enum:

	(enum format_lengths) 0		=> FMT_LEN_none
	(enum format_std_version) 0	=> STD_C89

If you make those changes, and it passes bootstrap, then consider the patch
approved.

> Also, it would seem reasonable to me if, for very intrusive patches  
> such as enabling new warnings to bootstrap, they were tested on  
> primary and secondary platforms.

Well it would be nice, but the reality is it can be hard to get a coordinated
effort to check on all of the platforms.

-- 
Michael Meissner, IBM
4 Technology Place Drive, MS 2203A, Westford, MA, 01886, USA
meissner@linux.vnet.ibm.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]