This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [plugins] Add user attribute(try #2)


On Tue, May 12, 2009 at 20:38, Taras Glek <tglek@mozilla.com> wrote:

> The testcase has 2 XFails which will turn to PASSes once decl smashing fix
> lands (http://gcc.gnu.org/ml/gcc-patches/2009-05/msg00657.html)

Please commit that patch before this one.  Adding XFAIL tests is
not a good idea.

> +        register_attribute (&attribute_tables[i][k]);
> +      }
> +  invoke_plugin_callbacks (PLUGIN_ATTRIBUTES, NULL);
> +  attributes_initialized = true;
> +}
> +
> +/* Insert a single attribute into the attribute table */

End comments with '.  */'
ATTR needs to be documented.  The convention is to capitalize the
argument's name when referring to it.  See other comments for
examples.

> +/* in attribs.c */

/* In attribs.c.  */


> +} // { dg-warning "attribute 'user' on param 'c' of function method" "" { xfail *-*-* } }

Remove the XFAIL here.

OK with those changes.


Diego.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]