This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [plugins] Add user attribute(try #2)
- From: Diego Novillo <dnovillo at google dot com>
- To: Taras Glek <tglek at mozilla dot com>
- Cc: Le-Chun Wu <lcwu at google dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>, Richard Guenther <richard dot guenther at gmail dot com>, gcc-patches at gcc dot gnu dot org
- Date: Wed, 13 May 2009 08:31:09 -0400
- Subject: Re: [plugins] Add user attribute(try #2)
- References: <49D25E40.6080507@mozilla.com> <84fc9c000904010146j53e49ed9i6c271751d41dfd42@mail.gmail.com> <Pine.LNX.4.64.0904011257550.14922@digraph.polyomino.org.uk> <49D398C9.1010809@mozilla.com> <82091ad70904021448y71547117q9fbd21cb8bd5b94d@mail.gmail.com> <49EFA543.8030602@mozilla.com> <b798aad50905120523g5bd39e0clac07d2019dff7778@mail.gmail.com> <4A0A169D.5020003@mozilla.com>
On Tue, May 12, 2009 at 20:38, Taras Glek <tglek@mozilla.com> wrote:
> The testcase has 2 XFails which will turn to PASSes once decl smashing fix
> lands (http://gcc.gnu.org/ml/gcc-patches/2009-05/msg00657.html)
Please commit that patch before this one. Adding XFAIL tests is
not a good idea.
> + register_attribute (&attribute_tables[i][k]);
> + }
> + invoke_plugin_callbacks (PLUGIN_ATTRIBUTES, NULL);
> + attributes_initialized = true;
> +}
> +
> +/* Insert a single attribute into the attribute table */
End comments with '. */'
ATTR needs to be documented. The convention is to capitalize the
argument's name when referring to it. See other comments for
examples.
> +/* in attribs.c */
/* In attribs.c. */
> +} // { dg-warning "attribute 'user' on param 'c' of function method" "" { xfail *-*-* } }
Remove the XFAIL here.
OK with those changes.
Diego.