This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: ERFC_SCALED compile-time simplification

From: FX <fxcoudert at gmail dot com>
To: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
Cc: Fortran List <fortran at gcc dot gnu dot org>, gcc-patches at gcc dot gnu dot org
Date: Tue, 12 May 2009 20:58:34 +0200
Subject: Re: ERFC_SCALED compile-time simplification
References: <BBCDD4EA-4ABD-4A9F-A7C7-11798F9B64B9@gmail.com> <20090512185051.GA96119@troutmask.apl.washington.edu>

You have memory leaks in some of the functions.  If you
have an mpfr_init(), then you should have a companion
mpfr_clear().  If you have multiple items to free, you
can use mpfr_clears(a, b, c, NULL).

Oh, shoot, I should have run valgrind.

Otherwise, I believe the code is ok to commit.  Do
you want me to fix the leaks, and do the commit?

I now have svn write access again, so I can commit stuff. But I won't have time for another week or more, so if you have time to do that, it would be great. Otherwise, I know there's more important stuff than this kind of patches and I'll do it whenever I get some time.

FX

References:
- ERFC_SCALED compile-time simplification
  - From: FX
- Re: ERFC_SCALED compile-time simplification
  - From: Steve Kargl

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]