This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] Fix FMT= with CHARACTER arrays (PR fortran/39865, take 2)
On Tue, May 12, 2009 at 11:41:58AM -0700, Steve Kargl wrote:
> > +
> > +static void
> > +gfc_array_parameter_size (tree desc, gfc_expr *expr, tree *size)
> I don't know if this conforms to the Gnu Code Standard, but by
> convention the gfortran guys normally do not use the gfc_
> prefix on static functions. Yes, there is an inconsistent
> adherence to this rule in other code.
> > /* Deallocate the allocatable components of structures that are
> > --- gcc/fortran/trans-io.c.jj 2009-05-04 16:46:12.000000000 +0200
> > +++ gcc/fortran/trans-io.c 2009-05-12 17:29:32.000000000 +0200
> > + if (0 && e->expr_type == EXPR_VARIABLE
> > + && e->ref->u.ar.type == AR_FULL
> > + && e->symtree
> > + && e->symtree->n.sym->backend_decl
> > + && GFC_DECL_PACKED_ARRAY (e->symtree->n.sym->backend_decl))
> Why the '0' in the above?
Ah, thanks for catching this. I initially had this hunk in, then tested
that the if is actually unnecessary because the gfc_conv_array_parameter
call below it generates identical code. So I'll remove this whole if.