This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [plugins] Add user attribute(try #2)


On Wed, Apr 22, 2009 at 19:16, Taras Glek <tglek@mozilla.com> wrote:

> +void
> +register_attribute (const struct attribute_spec *attr)
> +{

Needs comment.

> --- a/gcc/gcc-plugin.h
> +++ b/gcc/gcc-plugin.h
> @@ -29,6 +29,7 @@ enum plugin_event
>    PLUGIN_CXX_CP_PRE_GENERICIZE, /* Allows to see low level AST in C++ FE.  */
>    PLUGIN_FINISH,                /* Called before GCC exits.  */
>    PLUGIN_INFO,                  /* Information about the plugin */
> +  PLUGIN_ATTRIBUTES,            /* Called during attribute registration */

Needs to be added to plugins.texi.

Also, could you add a testcase and documentation on how plugins
should use this mechanism?

Finally, the patch needs a ChangeLog entry.


Thanks.  Diego.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]