This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Add missing return false to ipcp_cloning_candidate_p
- From: Jan Hubicka <hubicka at ucw dot cz>
- To: Martin Jambor <mjambor at suse dot cz>, gcc-patches at gcc dot gnu dot org
- Date: Mon, 11 May 2009 23:03:28 +0200
- Subject: Re: Add missing return false to ipcp_cloning_candidate_p
- References: <20090511210020.GB4987@virgil.suse.cz>
> Hi,
>
> There was a missing return false in ipcp_cloning_candidate_p(). Honza
> asked me to add it so I have committed the following patch as revision
> 147396 after bootstrapping and testing it on x86-64-linux.
Thanks. Note that this is technically regression in 4.4 (i.e. we grow
code size here with no benefit), so it might be applicable also for
4.4.1 if we notice it causes some improvements.
Honza
>
> Martin
>
>
>
> 2009-05-11 Martin Jambor <mjambor@suse.cz>
>
> * ipa-cp.c (ipcp_cloning_candidate_p): Add missing return false.
>
>
> Index: gcc/ipa-cp.c
> ===================================================================
> --- gcc/ipa-cp.c (revision 147389)
> +++ gcc/ipa-cp.c (working copy)
> @@ -438,6 +438,7 @@ ipcp_cloning_candidate_p (struct cgraph_
> if (dump_file)
> fprintf (dump_file, "Not considering %s for cloning; no hot calls.\n",
> cgraph_node_name (node));
> + return false;
> }
> if (dump_file)
> fprintf (dump_file, "Considering %s for cloning.\n",