This is the mail archive of the
mailing list for the GCC project.
Re: [patch, committed] Obvious fix in Fortran.
- From: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
- To: sje at cup dot hp dot com
- Cc: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Mon, 11 May 2009 18:13:09 +0200
- Subject: Re: [patch, committed] Obvious fix in Fortran.
- References: <200905111526.n4BFQtm21003@lucas.cup.hp.com>
Thanks Steve! I was the author of this error :-(
On Mon, May 11, 2009 at 5:26 PM, Steve Ellcey <email@example.com> wrote:
> My bootstrap was broken with:
> /src/trunk/gcc/fortran/resolve.c: In function 'check_host_association':
> /src/trunk/gcc/fortran/resolve.c:4356: error: 'tail' may be used uninitialized in this function
> make: *** [fortran/resolve.o] Error 1
> So I checked in this obvious patch to fix it. ?I don't know why this
> just showed up, it doesn't look like resolve.c was changed recently
> so it must have been a change in GCC's unitialized variable checking method.
> Steve Ellcey
> 2009-05-11 ?Steve Ellcey ?<firstname.lastname@example.org>
> ? ? ? ?* resolve.c (check_host_association): Initialize tail.
> Index: resolve.c
> --- resolve.c ? (revision 147380)
> +++ resolve.c ? (working copy)
> @@ -4353,7 +4353,7 @@ check_host_association (gfc_expr *e)
> ? gfc_symtree *st;
> ? int n;
> ? gfc_ref *ref;
> - ?gfc_actual_arglist *arg, *tail;
> + ?gfc_actual_arglist *arg, *tail = NULL;
> ? bool retval = e->expr_type == EXPR_FUNCTION;
> ? /* ?If the expression is the result of substitution in
The knack of flying is learning how to throw yourself at the ground and miss.
--Hitchhikers Guide to the Galaxy