This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [4.3 patch] fix build failure if MIPS_DEBUGGING_INFO is defined
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Matthias Klose <doko at ubuntu dot com>
- Cc: fortran at gcc dot gnu dot org, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 11 May 2009 10:30:49 +0200
- Subject: Re: [4.3 patch] fix build failure if MIPS_DEBUGGING_INFO is defined
- References: <4A07D7A6.1060701@ubuntu.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Mon, May 11, 2009 at 09:45:42AM +0200, Matthias Klose wrote:
> The backport for PR39791 breaks the build on mips*-linux and alpha-linux. Of for
> the fix on the 4.3 branch?
> 2009-05-11 Matthias Klose <doko@ubuntu.com>
>
> * dwarf2out.c (add_subscript_info): Don't use dimension_number
> if MIPS_DEBUGGING_INFO is defined.
>
> --- gcc/dwarf2out.c~ 2009-05-10 14:41:22.000000000 +0200
> +++ gcc/dwarf2out.c 2009-05-11 09:22:25.000000000 +0200
> @@ -11324,7 +11324,11 @@
> {
> tree domain = TYPE_DOMAIN (type);
>
> - if (TYPE_STRING_FLAG (type) && is_fortran () && dimension_number > 0)
> + if (TYPE_STRING_FLAG (type) && is_fortran ()
> +#ifndef MIPS_DEBUGGING_INFO
> + && dimension_number > 0
> +#endif
> + )
> break;
This is incorrect. bugzilla has a correct fix, for MIPS_DEBUGGING_INFO you
should assume dimension_number is always 0 (SGI dwarf reader didn't handle
multidimensional arrays).
Jakub