This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: PR c/36892: Support __attribute__((deprecated("text string")))


On Fri, May 8, 2009 at 7:12 AM, Manuel López-Ibáñez
<lopezibanez@gmail.com> wrote:
> 2009/5/8 H.J. Lu <hjl.tools@gmail.com>:
>> On Fri, May 8, 2009 at 3:25 AM, Joseph S. Myers <joseph@codesourcery.com> wrote:
>>> On Thu, 7 May 2009, H.J. Lu wrote:
>>>
>>>> Here is the updated patch. ?dg.exp doesn't support the same
>>>> regexp with dg-warning at different lines. I can only put
>>>> regexp at the last dg-warning. Are C and C++ parts OK?
>>>
>>> I don't understand what you are claiming doesn't work with dg-warning; I
>>> know of no such issue with dg.exp.
>>>
>>
>> There are several warnings. We will try to match them with
>>
>> /* { dg-warning "'f1' is deprecated .declared at .*.: Please avoid f1" "" } */
>>
>
> You should never use ".*" in regexp because "." includes '\n' and the
> match is greedy, so it will match several lines. Either use several
> dg-warning
>
> /* { dg-warning "'f1' is deprecated .declared at" "" } */
> /* { dg-warning "Please avoid f1" "" { target *-*-* } line } */
>
> or use "\[^\n\]*" instead of ".*"
>

Here is the updated patch. Tested on Linux/Intel64. Are C and C++
parts OK for trunk?

Thanks.



-- 
H.J.

Attachment: gcc-deprecated-8.patch
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]