This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [trunk][patch] Install headers and plugin-version.o


* Rafael Espindola wrote on Wed, May 06, 2009 at 10:43:47AM CEST:
> Is the attached patch OK?

FWIW, I don't see problems with it either, but

> --- a/gcc/Makefile.in
> +++ b/gcc/Makefile.in
> @@ -4020,8 +4020,9 @@ install-plugin: installdirs
>  	  else continue; \
>  	  fi; \
>  	  case $$path in \
> -	  "$(srcdir)"*/config/* | "$(srcdir)"*.def ) \
> -	    base=`echo $$path | sed "s|$(srcdir)||"`;; \
> +	  "$(srcdir)"*/config/* | "$(srcdir)"/*.def ) \

I fail to understand what first '*' in this line is supposed to be good
for.

> +	    srcdirstrip=`echo "$(srcdir)" | sed 's/[].[^$$\\*|]/\\\\&/g'`; \

You could hoist this assignment (including fork and all) out of the
loop.

> +	    base=`echo "$$path" | sed -e "s|$$srcdirstrip/||"`;; \
>  	  *) base=`basename $$path` ;; \
>  	  esac; \
>  	  dest=$(plugin_includedir)/$$base; \

Thanks,
Ralf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]