This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH c/middle-end] Replace vector_opaque_p with a bit in the type


On Wed, Apr 15, 2009 at 9:10 PM, Richard Guenther
<richard.guenther@gmail.com> wrote:
> On Wed, Apr 15, 2009 at 7:20 PM, Joseph S. Myers
> <joseph@codesourcery.com> wrote:
>> On Wed, 15 Apr 2009, Paolo Bonzini wrote:
>>
>>> Paolo Bonzini wrote:
>>> > I think I've already posted the patch, but it never was committed.
>>> > Since these types are never created by the user (e.g. with attributes),
>>> > it makes less sense in my opinion to use a target hook than for
>>> > TARGET_MS_BITFIELD_TYPE_P.
>>> >
>>> > Ok for 4.5?
>>>
>>> Fixed the changelog, and tested on powerpc-eabispe. ?Bootstrap/regtest
>>> on i686-pc-linux-gnu will run overnight.
>>
>> The C front-end changes in this patch are OK.
>
> The middle-end changes as well.

Please fix

+/* Nonzero in an IDENTIFIER_NODE if the name is a local alias, whose
+   uses are to be substituted for uses of the TREE_CHAINed identifier.  */
+#define TYPE_VECTOR_OPAQUE(NODE) \
+  (VECTOR_TYPE_CHECK (NODE)->base.deprecated_flag)

you may also want to provide hints to PR40009 and how the above should
affect the gimple type system (I think it should not - instead the frontend
should insert VIEW_CONVERT_EXPRs here).

Richard.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]