This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, pretty-ipa] Fix wave ICE in SRA
On Sat, May 2, 2009 at 9:31 PM, Michael Matz <matz@suse.de> wrote:
> Hi,
>
> On Sat, 2 May 2009, Eric Botcazou wrote:
>
>> > Then, at the very least it needs some asserts to ensure that no invalid
>> > calls happen (same for get_ref_base_and_extent), because passing DECLs
>> > _seems_ to work, but leads to hard to spot errors.
>>
>> Yes, an assert probably cannot hurt. ?It's one of the most specified
>> functions in the compiler though so I'm a little surprised by all the
>> fuss about it.
>
> It's no fuss, I can just say that I was surprised by the specification and
> felt it was unnatural :-)
Note that it is on purpose that get_ref_base_and_extent deals with plain decls.
Things will break if it doesn't.
Richard.