This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Ping Re: [C++/diagnostics] Pretty-printing identifiers handling cleanup


On Fri, May 1, 2009 at 8:45 AM, Joseph S. Myers <joseph@codesourcery.com> wrote:
> On Fri, 1 May 2009, Gabriel Dos Reis wrote:
>
>> On Thu, Apr 30, 2009 at 6:21 PM, Joseph S. Myers
>> <joseph@codesourcery.com> wrote:
>> > Ping. ?The (fairly mechanical) non-i18n C++ changes in this patch
>> > <http://gcc.gnu.org/ml/gcc-patches/2009-04/msg02075.html> are pending
>> > review.
>>
>> Why do you translate ?the ellipsis "..." ?for translation in the
>> template parameter case?
>> They are used as keywords.
>
> I don't see any place where I do translate it. ?I change it from going
> through pp_cxx_identifier to pp_cxx_ws_string or pp_identifier to
> pp_string because it is not an identifier and does not need any character
> set conversions.

Aha, you are absolutely right.  sorry, I confused that part with something
else.

I've gone through the rest of your patch, and it llooks OK to me.

PS:  Please, CC: to gdr at cs dot tamu dot edu for patch reviews.

-- Gaby


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]