This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Enable -fstack-protector on MIPS


On Thu, 2009-04-30 at 14:08 -0700, Adam Nemet wrote:
> Richard Sandiford writes:
> > Adam Nemet <anemet@caviumnetworks.com> writes:
> > > 	* config/mips/mips.h (FRAME_GROWS_DOWNWARD,
> > > 	MIPS_GP_SAVE_AREA_SIZE): Define new macros.
> > > 	(STARTING_FRAME_OFFSET): Return 0 if FRAME_GROWS_DOWNWARD.  Use
> > > 	MIPS_GP_SAVE_AREA_SIZE.
> > > 	* config/mips/mips.c (struct mips_frame_info): Update comment
> > > 	before arg_pointer_offset and hard_frame_pointer_offset.
> > > 	(mips_compute_frame_info): Update diagram before function: to
> > > 	correctly use stack_pointer_rtx for fp_sp_offset and gp_sp_offset, to
> > > 	indicate the position of frame_pointer_rtx with -fstack-protector and
> > > 	to show args_size.  Don't allocate cprestore area for leaf functions
> > > 	if FRAME_GROWS_DOWNWARD.  Use MIPS_GP_SAVE_AREA_SIZE to set
> > > 	cprestore_size.
> > > 	(mips_initial_elimination_offset): Update for FRAME_GROWS_DOWNWARD.
> 
> Thanks.
> 
> Janis, Richard,
> 
> Can the related testsuite patch go in as well:
> 
>   http://gcc.gnu.org/ml/gcc-patches/2009-04/msg02192.html
> 
> ?  Without it the above patch produces an additional failure.

OK.

Janis


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]