This is the mail archive of the
mailing list for the GCC project.
Re: [patch][plugins] Check the gcc version
On Wed, Apr 29, 2009 at 12:14 PM, Richard Guenther
> On Wed, Apr 29, 2009 at 3:21 PM, Rafael Espindola <firstname.lastname@example.org> wrote:
>>> Minor nit: No need to include generated files in patches.
>>> This needs changes in the testsuite patch, right? ?I'll take care of
>>> it on my local patch before I submit it to mainline.
>> Yes. Good catch, should have warned you.
> This has broken bootstrap.
> See http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39968.
The bootstrap failure on the Darwin systems was caused by the
./plugin-version.h:11: error: 'gcc_version' defined but not used
The sole use of gcc_version in plugin.c is in function
try_init_one_plugin, which is guarded by the macro ENABLE_PLUGIN.
Since ENABLE_PLUGIN is set to 0 on the Darwin systems, the function
was compiled out. Rafael, I think we need to guard the inclusion of
plugin-version.h with ENABLE_PLUGIN as well.