This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Hookize (partially) GO_IF_LEGITIMATE_ADDRESS


MIPS parts are OK, thanks, but...

Paolo Bonzini <bonzini@gnu.org> writes:
> Index: gcc/config/mips/mips.c
> ===================================================================
> --- gcc/config/mips/mips.c	(revision 146581)
> +++ gcc/config/mips/mips.c	(working copy)
> @@ -2122,7 +2122,7 @@ mips_classify_address (struct mips_addre
>  /* Return true if X is a legitimate address for a memory operand of mode
>     MODE.  STRICT_P is true if REG_OK_STRICT is in effect.  */
>  
> -bool
> +static bool
>  mips_legitimate_address_p (enum machine_mode mode, rtx x, bool strict_p)
>  {
>    struct mips_address_info addr;

...please change the comment to just:

  /* Implement TARGET_LEGITIMATE_ADDRESS_P.  */

(E.g. it seems better not to mention REG_OK_STRICT in this context
after the patch.)

Richard


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]