This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [debuglocus] fix vectorizer and mudflap sharing


Aldy Hernandez wrote:
This patch fixes the remaining debuglocus sharing violations.  We can
now bootstrap with no testsuite regressions, while forcing sharing
verification.

Andrew, I've made create_duplicate_debuglocus() work with plain location
entries, and just return the location.  This simplifies things a bit.  I
can change the caller to do the check if you prefer.

Thats fine.
[I've been thinking that perhaps it's better to have
gimple_set_location() accept a boolean specifying whether to to call
create_duplicate_debuglocus() automatically. Also, what do you think

I don't think I want to take that step just yet.
about checking for duplicate entries by default and aborting-- at least
during development.]

The only problem is that initially the RTL side is going to have a bunch of duplicates, but maybe that will be ok, force me to fix them as I go.

Sure, make it abort for now.
OK for branch?

OK.


Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]