This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] SSA expand: Convert mode when copying between partition base vars


Hi,

On Tue, 28 Apr 2009, Andreas Krebbel wrote:

> Ok for mainline in case the other bootstraps succeed as well?
> 
> +/* Emit insns to copy SRC into DEST converting SRC if necessary.  */
> +
> +static inline void
> +do_partition_copy (rtx dest, rtx src, int unsignedsrcp)
> +{
> +  if (GET_MODE (src) != GET_MODE (dest))
> +    src = convert_to_mode (GET_MODE (dest), src, unsignedsrcp);
> +  emit_move_insn (dest, src);
> +}
> +

Put the start_sequence/get_insns/end_sequence here too, and return an rtx 
(the get_insns() return value).  With those changes I would be fine with 
the patch, but I can't approve it.


Ciao,
Michael.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]