This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PING][PATCH]: Allow CFG with empty BBs in selective scheduler


Alexander Monakov wrote:
Hi,

I'm not sure if this may count as a regression, as empty basic blocks are
rarely expected at the start of second scheduling pass (the testcase enables
selective scheduling at -Os to reproduce). OK for stage 1?
Thanks, Alexander. The patch is ok to commit it into the trunk.

Please, only merge two changelog entries for sel-sched-ir.c into one:

* sel-sched-ir.c (maybe_tidy_empty_bb): Do not attempt to delete a block if there are complex incoming edges.
(sel_merge_blocks): Remove useless assert.
(sel_redirect_edge_and_branch): Check that edge was redirected.
* sel-sched-ir.h (_eligible_successor_edge_p): Remove assert.
(sel_find_rgns): Delete declaration.



The patch would be more readable if you used -up in diff. Please, remember about this next time.


Vlad




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]