This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Add multilib config for powerpc-xilinx-eabi


Michael Eager wrote:
David Edelsohn wrote:
On Wed, Apr 22, 2009 at 8:35 PM, Michael Eager <eager@eagercon.com> wrote:
Add multilib configuration for powerpc-xilinx-eabi.
Tested with --target=powerpc-eabisim.


2009-04-22 Michael Eager <eager@eagercon.com>


       * config/rs6000/t-xilinx: New, multilib for Xilinx PPC with
       single/double precision FPU.
       * config.gcc: Replace t-ppcgas & t-ppccomm with t-xilinx for
       powerpc-xilinx-eabi.

Michael,


I am concerned about the direction this patch is taking Xilinx
support.  The patch probably is correct, but this patch is duplicating
a lot of t-ppcgas and t-ppccomm instead of factoring out the changes
for t-xilinx.  The problem is future maintenance.  If someone needs to
fix something in t-ppcgas or t-ppccomm in the future, they may not
notice to check t-xilinx and change t-xilinx as well.  t-xilinx also
loses on the common testing.

Ok, I'll look at making t-xilinx just override or augument t-ppcgas & t-ppccomm.

Revised patch attached.



-- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
Index: gcc/config.gcc
===================================================================
--- gcc/config.gcc	(revision 146610)
+++ gcc/config.gcc	(working copy)
@@ -1795,7 +1795,7 @@
 powerpc-xilinx-eabi*)
 	tm_file="${tm_file} dbxelf.h elfos.h usegas.h svr4.h freebsd-spec.h newlib-stdint.h rs6000/sysv4.h rs6000/eabi.h rs6000/singlefp.h rs6000/xfpu.h rs6000/xilinx.h"
 	extra_options="${extra_options} rs6000/sysv4.opt"
-	tmake_file="rs6000/t-fprules rs6000/t-fprules-fpbit rs6000/t-ppcgas rs6000/t-ppccomm"
+	tmake_file="rs6000/t-fprules rs6000/t-fprules-fpbit rs6000/t-ppcgas rs6000/t-ppccomm rs6000/t-xilinx"
 	use_gcc_stdint=wrap
 	;;
 powerpc-*-eabi*)
Index: gcc/config/rs6000/t-xilinx
===================================================================
--- gcc/config/rs6000/t-xilinx	(revision 0)
+++ gcc/config/rs6000/t-xilinx	(revision 0)
@@ -0,0 +1,28 @@
+# Multilibs for Xilinx powerpc embedded ELF targets.
+#
+# Copyright (C) 2009 Free Software Foundation, Inc.
+# Contributed by Michael Eager, eager@eagercon.com
+#
+# This file is part of GCC.
+#
+# GCC is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3, or (at your option)
+# any later version.
+#
+# GCC is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with GCC; see the file COPYING3.  If not see
+# <http://www.gnu.org/licenses/>.
+
+# Switch synonyms
+MULTILIB_MATCHES        = mfpu?sp_lite=msingle-float mfpu?dp_lite=mdouble-float mfpu?dp_lite=mhard-float mfpu?sp_lite=mfpu?sp_full mfpu?dp_lite=mfpu?dp_full 
+
+MULTILIB_OPTIONS        = mfpu=sp_lite/mfpu=dp_lite 
+
+MULTILIB_DIRNAMES       = single double 
+

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]