This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Add multilib config for powerpc-xilinx-eabi
- From: David Edelsohn <dje dot gcc at gmail dot com>
- To: Michael Eager <eager at eagercon dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 23 Apr 2009 14:51:00 -0400
- Subject: Re: Add multilib config for powerpc-xilinx-eabi
- References: <49EFB7BF.80107@eagercon.com>
On Wed, Apr 22, 2009 at 8:35 PM, Michael Eager <eager@eagercon.com> wrote:
> Add multilib configuration for powerpc-xilinx-eabi.
> Tested with --target=powerpc-eabisim.
>
>
> 2009-04-22 ?Michael Eager <eager@eagercon.com>
>
> ? ? ? ?* config/rs6000/t-xilinx: New, multilib for Xilinx PPC with
> ? ? ? ?single/double precision FPU.
> ? ? ? ?* config.gcc: Replace t-ppcgas & t-ppccomm with t-xilinx for
> ? ? ? ?powerpc-xilinx-eabi.
Michael,
I am concerned about the direction this patch is taking Xilinx
support. The patch probably is correct, but this patch is duplicating
a lot of t-ppcgas and t-ppccomm instead of factoring out the changes
for t-xilinx. The problem is future maintenance. If someone needs to
fix something in t-ppcgas or t-ppccomm in the future, they may not
notice to check t-xilinx and change t-xilinx as well. t-xilinx also
loses on the common testing.
David