This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: PR target/39590: inline asm %z on amd64 says "ll" instead of "q"


On Wed, Apr 22, 2009 at 02:22:03PM +0200, Uros Bizjak wrote:
> On Wed, Apr 1, 2009 at 9:08 PM, H.J. Lu <hongjiu.lu@intel.com> wrote:
> 
> > Gcc generates "movll" for asm statement with "mov%z1" on a DImode memory.
> > The problem is "%z" was never updated for 64bit. We can't generate 'q'
> > for "%z" due to "fild%z1\t%1" in i386.md. Not all x86-64 assemblers
> > support "fildq".  This patch checks if assembler supports fildq and
> > generates fildq/movq when it works.  OK for trunk?
> 
> I think that we should move special fild/fist handling out of 'z' into
> new 'Z' operand modifier. This simplifies code a lot, and enables all
> sorts of special fild/fist handling to be handled in one place without
> overloading (otherwise undocumented!) 'z' modifier too much.

Wouldn't it be better to keep %zN as is and add %ZN which would expand
to q instead of ll for 64-bit operand?
When a new modifier is added, I don't see any advantages of modifying the
behaviour of %zN.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]