This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Emit accurate debug info for short-circuit operators


On Mon, 20 Apr 2009, Eric Botcazou wrote:

> 	* c-common.c (c_common_truthvalue_conversion): Use LOCATION to build
> 	NE_EXPR operations as well.
> 	* c-parser.c (c_parser_condition): Do not set location information on
> 	the condition.
> 	(c_parser_conditional_expression): Likewise.
> 	(c_parser_binary_expression): Set location information on operators.

These changes are OK.

> 	* c-typeck.c (build_unary_op) <TRUTH_NOT_EXPR>: Reset the location if
> 	TRUTH_NOT_EXPR has been folded.

Could you explain why this is needed in more detail?  Why isn't the 
location passed in to build_unary_op always appropriate for the final 
location setting?

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]