This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PR c/c++/16202 The -Wsequence-point warning misses many important instances
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Manuel López-Ibáñez <lopezibanez at gmail dot com>
- Cc: Gcc Patch List <gcc-patches at gcc dot gnu dot org>, Jason Merrill <jason at redhat dot com>, Mark Mitchell <mark at codesourcery dot com>, Nathan Sidwell <nathan at codesourcery dot com>
- Date: Sun, 19 Apr 2009 20:49:03 +0000 (UTC)
- Subject: Re: PR c/c++/16202 The -Wsequence-point warning misses many important instances
- References: <6c33472e0810241019s9d1a6cdoae9faf6280cc8795@mail.gmail.com> <6c33472e0904100536o2b1c5e6fmf5bbf7cfafb1b02e@mail.gmail.com> <6c33472e0904190419m39e53b6bmc8428c187886b20d@mail.gmail.com>
On Sun, 19 Apr 2009, Manuel López-Ibáñez wrote:
> PING: http://gcc.gnu.org/ml/gcc-patches/2009-04/msg00796.html
>
> 2009/4/10 Manuel López-Ibáñez <lopezibanez@gmail.com>:
> > Updated to a recent revision, bootstrapped and regression tested on
> > x86_64-unknown-linux-gnu with --enable-languages=all
> >
> > OK for trunk?
> >
> > 2009-04-10 ?Manuel López-Ibáñez ?<manu@gcc.gnu.org>
> >
> > ? ? ? ?PR 16202
> > ? ? ? ?* c-typeck.c (lvalue_p): Move declaration ...
> > ? ? ? ?* c-common.h (lvalue_p): ... to here.
> > ? ? ? ?* c-common.c (candidate_equal_p): New.
> > ? ? ? ?(add_tlist): Use it.
> > ? ? ? ?(merge_tlist): Use it.
> > ? ? ? ?(warn_for_collisions_1): Likewise.
> > ? ? ? ?(warning_candidate_p): Accept more candidates.
> > ? ? ? ?(verify_tree): A warning candidate can be an expression. Use
> > ? ? ? ?candidate_equal_p.
> > cp/
> > ? ? ? ?* tree.c (lvalue_p_1): Use const_tree.
> > ? ? ? ?Use CONST_CAST_TREE to avoid warning.
> > ? ? ? ?(lvalue_p): Returns bool, receives const_tree.
> >
> > testsuite/
> > ? ? ? ?* gcc.dg/sequence-pt-1.c: Remove XFAILs.
> > ? ? ? ?* gcc.dg/sequence-pt-2.c: New.
> > ? ? ? ?* gcc.dg/sequence-pt-3.c: New.
> > ? ? ? ?* g++.dg/warn/sequence-pt-1.C: Remove XFAILs.
> > ? ? ? ?* g++.dg/warn/sequence-pt-2.c: New.
> > ? ? ? ?* g++.dg/warn/sequence-pt-3.c: New.
The C parts of this patch are OK.
--
Joseph S. Myers
joseph@codesourcery.com