This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: newlib stdint INTPTR_MAX etc fixincludes patch


On Sun, 19 Apr 2009, Hans-Peter Nilsson wrote:

> > Date: Thu, 16 Apr 2009 16:40:58 -0700
> > From: Bruce Korb <bkorb@gnu.org>
> 
> > Hans-Peter Nilsson wrote:
> > >> or a corresponding 
> > >> fixincludes patch is applied;
> > > 
> > > Not exactly the same: by brief inspection of results and log,
> > > apparently fixincludes isn't run when newlib is compiled in a
> > > "combined tree" (with newlib a sibling subdir of gcc) so it
> > > doesn't help at least in my usual setup.
> > 
> > I'm a little confused about the meaning of this.
> 
> It effectively means the fixincludes patch has no effect,
> because fixincludes isn't run in the arguably "most common"
> installation scenario for newlib, which IMHO makes the patch
> less desirable.

It's reasonable to expect that people using a combined tree are using a 
current version of newlib (i.e. one postdating the fix being checked into 
the newlib sources, presuming that happens before 4.5 branches); 
fixincludes should cover all the other uses of newlib not with a combined 
tree.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]