This is the mail archive of the
mailing list for the GCC project.
Re: newlib stdint INTPTR_MAX etc fixincludes patch
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- Cc: bkorb at gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Sun, 19 Apr 2009 11:07:28 +0000 (UTC)
- Subject: Re: newlib stdint INTPTR_MAX etc fixincludes patch
- References: <200904182338.n3INcc9g005945@ignucius.se.axis.com>
On Sun, 19 Apr 2009, Hans-Peter Nilsson wrote:
> > Date: Thu, 16 Apr 2009 16:40:58 -0700
> > From: Bruce Korb <email@example.com>
> > Hans-Peter Nilsson wrote:
> > >> or a corresponding
> > >> fixincludes patch is applied;
> > >
> > > Not exactly the same: by brief inspection of results and log,
> > > apparently fixincludes isn't run when newlib is compiled in a
> > > "combined tree" (with newlib a sibling subdir of gcc) so it
> > > doesn't help at least in my usual setup.
> > I'm a little confused about the meaning of this.
> It effectively means the fixincludes patch has no effect,
> because fixincludes isn't run in the arguably "most common"
> installation scenario for newlib, which IMHO makes the patch
> less desirable.
It's reasonable to expect that people using a combined tree are using a
current version of newlib (i.e. one postdating the fix being checked into
the newlib sources, presuming that happens before 4.5 branches);
fixincludes should cover all the other uses of newlib not with a combined
Joseph S. Myers