This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [committed][lto merge]: Various minor fixes


On Fri, Apr 17, 2009 at 17:55, Richard Guenther
<richard.guenther@gmail.com> wrote:

>> +void
>> +find_referenced_vars_in (gimple stmt)
>
> Why export this function? ÂAre there outside uses on the branch?

Yes.  I forgot to mention that, sorry.  I'll commit the code to use it
when I start moving in LTO-specific changes.


>> @@ -3003,6 +3003,7 @@ create_expression_by_pieces (basic_block
>> Â Â Â Â Â Â Âadd_to_value (VN_INFO (forcedname)->value_id, nameexpr);
>> Â Â Â Â Â Â Âif (!in_fre)
>> Â Â Â Â Â Â Â Âbitmap_value_replace_in_set (NEW_SETS (block), nameexpr);
>> + Â Â Â Â Â Â gcc_assert (AVAIL_OUT (block));
>
> Uh. ÂThat is odd. ÂWe certainly do not test this in other places and AVAIL_OUT
> is allocated for all blocks.
>
> Thus, can you instead revert it on the branch (and now trunk)?

*shrug*   It was useful when LTO was miscompiling types causing
confusion here.  I can remove the assertion if it irritates you.


Diego.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]