This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [4.5] [C++] PR32061 PR36954 Wlogical-op fixes


PING C++ parts:http://gcc.gnu.org/ml/gcc-patches/2009-04/msg00715.html

2009/4/9 Manuel López-Ibáñez <lopezibanez@gmail.com>:
> Updated to a recent revision, bootstrapped and regression tested on
> x86_64-unknown-linux-gnu.
>
> The C parts were already approved by Joseph.
>
> OK for trunk?
>
> Manuel.
>
> 2009-04-09 ?Manuel López-Ibáñez ?<manu@gcc.gnu.org>
>
> ? ? ? ?PR c/32061
> ? ? ? ?PR c++/36954
> ? ? ? ?* doc/invoke.texi: Add -Wlogical-op to -Wextra.
> ? ? ? ?* common.opt (Wlogical-op): Move from here...
> ? ? ? ?* c.opt (Wlogical-op): ... to here.
> ? ? ? ?* c-typeck.c (parser_build_binary_op): Update call to
> ? ? ? ?warn_logical_operator.
> ? ? ? ?* c-opts.c (c_common_post_options): Enable warn_logical_op with
> ? ? ? ?extra_warnings.
> ? ? ? ?* c-common.c (warn_logical_op): Update.
> ? ? ? ?* c-common.h (warn_logical_op): Update declaration.
> cp/
> ? ? ? ?* call.c (build_new_op): Save the original codes of operands
> ? ? ? ?before folding.
>
> testsuite/
> ? ? ? ?* gcc.dg/pr32061.c: New.
> ? ? ? ?* gcc.dg/Wlogical-op-1.c: Update.
> ? ? ? ?* g++.dg/warn/Wlogical-op-1.C: Update.
> ? ? ? ?* g++.dg/warn/pr36954.C: New.
>
>
>
>
> 2009/2/18 Manuel López-Ibáñez <lopezibanez@gmail.com>:
>> The following patch makes Wlogical-op warn less (in particular, not
>> warn for op && 1 or op && 0), it fixes two bugs and it also enables it
>> with Wextra. It also changes the wording of the warning from:
>>
>> logical '&&' with non-zero constant will always evaluate as true
>> logical '||' with non-zero constant will always evaluate as true
>>
>> to:
>>
>> logical 'and' applied to non-boolean constant
>> logical 'or' applied to non-boolean constant
>>
>> Bootstrapped and regression tested on x86_64-unknown-linux-gnu.
>>
>> OK for 4.5?
>>
>>
>> 2009-02-18 ?Manuel López-Ibáñez ?<manu@gcc.gnu.org>
>>
>> ? ? ? ?PR c/32061
>> ? ? ? ?PR c++/36954
>> ? ? ? ?* doc/invoke.texi: Add -Wlogical-op to -Wextra.
>> ? ? ? ?* common.opt (Wlogical-op): Move from here...
>> ? ? ? ?* c.opt (Wlogical-op): ... to here.
>> ? ? ? ?* c-typeck.c (parser_build_binary_op): Update call to
>> ? ? ? ?warn_logical_operator.
>> ? ? ? ?* c-opts.c (c_common_post_options): Enable warn_logical_op with
>> ? ? ? ?extra_warnings.
>> ? ? ? ?* c-common.c (warn_logical_op): Update.
>> ? ? ? ?* c-common.h (warn_logical_op): Update declaration.
>> cp/
>> ? ? ? ?* call.c (build_new_op): Save the original codes of operands
>> ? ? ? ?before folding.
>>
>> testsuite/
>> ? ? ? ?* gcc.dg/pr32061.c: New.
>> ? ? ? ?* gcc.dg/Wlogical-op-1.c: Update.
>> ? ? ? ?* g++.dg/warn/Wlogical-op-1.C: Update.
>> ? ? ? ?* g++.dg/warn/pr36954.C: New.
>>
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]