This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch testsuite/39790: gcc.dg/tls/alias-1.c,opt-2.c fail if TLS is not supported by C library


On Thu, 16 Apr 2009, Jing Yu wrote:

> +# This won't change for different subtargets so cache the result.

I don't believe this comment in this case; you can have both glibc and 
uClibc multilibs in one toolchain, for example, with the glibc multilibs 
supporting linking TLS code and the uClibc multilibs not supporting doing 
so.

Since the function does caching indirectly through functions that check 
for changes of target, I don't actually think there is a problem; avoiding 
any mention of caching here might be better (and in many of the other 
places that currently repeat the same comment).

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]