This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] ARM half-precision floating point, 8/8 (test cases)


Richard Guenther wrote:
> On Thu, Apr 16, 2009 at 12:29 AM, Sandra Loosemore
> <sandra@codesourcery.com> wrote:
>> Last piece of the half-precision puzzle!  Here are a lot of new test cases.
> 
> I'm missing a testcase that verifies what happens if I declare
> 
> float x __attribute__((mode(HF)));
> 
> on a target that doesn't support it.

It's failing for two reasons:

1) Sandra placed HFmode in config/arm/arm-modes.def (I think this makes
sense if she keeps the target hooks as they are, otherwise probably not).

2) The default implementation of scalar_mode_supported_p returns false
for HFmode.  So it fails even on ARM.

Probably a more sensible default implementation of
scalar_mode_supported_p would use have_regs_of_mode.  Or maybe
scalar_mode_supported_p should be ditched totally in favor of
have_regs_of_mode, but that would require auditing all targets that
support decimal floating-point and fixed-point arithmetic.

Paolo


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]