Re: [patch] except.c: Remove eh_region_outer_p.

[Richard Guenther <richard dot guenther at gmail dot com>]

On Thu, Apr 16, 2009 at 10:03 AM, Kazu Hirata <kazu@codesourcery.com> wrote:
> Hi,
>
> Attached is a patch to remove eh_region_outer_p.
>
> AFAICT, this function has been unused since:
>
> 2006-04-15 ?Jakub Jelinek ?<jakub@redhat.com>
>
> ? ? ? ?PR middle-end/26823
> ? ? ? ?* except.h (eh_region_outermost): New prototype.
> ? ? ? ?* except.c (eh_region_outermost): New function.
> ? ? ? ?* tree-cfg.c (find_outermost_region_in_block): Use it.
>
> Bootstrapped on x86_64-pc-linux-gnu. ?OK to apply?

Ok.

Thanks,
Richard.

> Kazu Hirata
>
> gcc/
> 2009-04-16 ?Kazu Hirata ?<kazu@codesourcery.com>
>
> ? ? ? ?* except.c (eh_region_outer_p): Remove.
> ? ? ? ?* except.h: Remove the prototype for eh_region_outer_p.
>
> Index: gcc/except.c
> ===================================================================
> --- gcc/except.c ? ? ? ?(revision 146080)
> +++ gcc/except.c ? ? ? ?(working copy)
> @@ -1224,32 +1224,6 @@ duplicate_eh_regions (struct function *i
> ? return eh_offset;
> ?}
>
> -/* Return true if REGION_A is outer to REGION_B in IFUN. ?*/
> -
> -bool
> -eh_region_outer_p (struct function *ifun, int region_a, int region_b)
> -{
> - ?struct eh_region *rp_a, *rp_b;
> -
> - ?gcc_assert (ifun->eh->last_region_number > 0);
> - ?gcc_assert (ifun->eh->region_tree);
> -
> - ?rp_a = VEC_index (eh_region, ifun->eh->region_array, region_a);
> - ?rp_b = VEC_index (eh_region, ifun->eh->region_array, region_b);
> - ?gcc_assert (rp_a != NULL);
> - ?gcc_assert (rp_b != NULL);
> -
> - ?do
> - ? ?{
> - ? ? ?if (rp_a == rp_b)
> - ? ? ? return true;
> - ? ? ?rp_b = rp_b->outer;
> - ? ?}
> - ?while (rp_b);
> -
> - ?return false;
> -}
> -
> ?/* Return region number of region that is outer to both if REGION_A and
> ? ?REGION_B in IFUN. ?*/
>
> Index: gcc/except.h
> ===================================================================
> --- gcc/except.h ? ? ? ?(revision 146080)
> +++ gcc/except.h ? ? ? ?(working copy)
> @@ -108,7 +108,6 @@ extern void collect_eh_region_array (voi
> ?extern void expand_resx_expr (tree);
> ?extern void verify_eh_tree (struct function *);
> ?extern void dump_eh_tree (FILE *, struct function *);
> -extern bool eh_region_outer_p (struct function *, int, int);
> ?extern int eh_region_outermost (struct function *, int, int);
>
> ?/* If non-NULL, this is a function that returns an expression to be
>