This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH c/middle-end] Replace vector_opaque_p with a bit in the type
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Paolo Bonzini <bonzini at gnu dot org>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 15 Apr 2009 14:00:17 +0000 (UTC)
- Subject: Re: [PATCH c/middle-end] Replace vector_opaque_p with a bit in the type
- References: <gs4mtb$dmu$1@ger.gmane.org>
On Wed, 15 Apr 2009, Paolo Bonzini wrote:
> * c-typeck.c (convert_for_assignment): Likewise, and on vectors
> rather than pointers.
> (really_start_incremental_init): Likewise.
> Index: gcc/c-typeck.c
> ===================================================================
> --- gcc/c-typeck.c (branch opaque-vectors)
> +++ gcc/c-typeck.c (working copy)
> @@ -5287,7 +5287,7 @@ really_start_incremental_init (tree type
> if (type == 0)
> type = TREE_TYPE (constructor_decl);
>
> - if (targetm.vector_opaque_p (type))
> + if (TYPE_VECTOR_OPAQUE (type))
> error ("opaque vector types cannot be initialized");
>
> p->type = constructor_type;
There seems to be something wrong with the log; there's a single change to
c-typeck.c but the log suggests more.
You also don't say how the patch has been tested (powerpc-eabispe might be
a suitable target for regression testing).
--
Joseph S. Myers
joseph@codesourcery.com