This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fwd: PATCH RFA: Implement -Wenum-compare for C


On Tue, 14 Apr 2009, Ian Lance Taylor wrote:

> "Joseph S. Myers" <joseph@codesourcery.com> writes:
> 
> > On Wed, 8 Apr 2009, Ian Lance Taylor wrote:
> >
> >> Ping.
> > [...]
> >> Joseph approved the patch earlier:
> >> 
> >> http://gcc.gnu.org/ml/gcc-patches/2008-09/msg00309.html
> >
> > So what are you pinging?  If there is some change from the previous patch 
> > that needs review, what is that change?
> 
> There are a number of minor changes, since the code has changed over the
> six months since the previous submission.  There are no significant
> changes.  I think the biggest change is that for a ternary conditional
> expression, if the original type of the second and third operands is the
> same, then that type treated as the original type of the whole
> condition.
> 
> If you are OK with the patch without a second detailed review, let me
> know.  Thanks.

Yes, I am OK with it without a second detailed review.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]